third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py - Issue 2578213005: Use underscores to separate words in filenames in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Patch Set: Fix check for attribute in output_capture.py. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py

similarity index 96%

rename from third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

rename to third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py

index 9822340a46e4eef2ba395d05a5ab4d164c8f1b6e..b136707bc322d6c2ee11927a5a9cc74e852f47e8 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py

@@ -23,10 +23,10 @@

import unittest

-from webkitpy.common.system.crashlogs import CrashLogs

+from webkitpy.common.system.crash_logs import CrashLogs

from webkitpy.common.system.filesystem_mock import MockFileSystem

-from webkitpy.common.system.systemhost import SystemHost

-from webkitpy.common.system.systemhost_mock import MockSystemHost

+from webkitpy.common.system.system_host import SystemHost

+from webkitpy.common.system.system_host_mock import MockSystemHost

def make_mock_crash_report_darwin(process_name, pid):

@@ -103,10 +103,10 @@ class CrashLogsTest(unittest.TestCase):

log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0)

self.assertIsNone(log)

- def bad_read(path):

+ def bad_read(_):

raise IOError('IOError: No such file or directory')

- def bad_mtime(path):

+ def bad_mtime(_):

raise OSError('OSError: No such file or directory')

filesystem.read_text_file = bad_read