third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py - Issue 2578213005: Use underscores to separate words in filenames in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_mock.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

similarity index 96%

rename from third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py

rename to third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

index f2222f92ac37dcef6a55a96878bc62e3fdc2d273..860fcd6a255eb623eb7e60675e7cc68fcb72fa69 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

@@ -118,7 +118,7 @@ class PlatformInfo(object):

packed = fcntl.ioctl(sys.stderr.fileno(), termios.TIOCGWINSZ, '\0' * 8)

_, columns, _, _ = struct.unpack('HHHH', packed)

return columns

- except:

+ except Exception: # pylint: disable=broad-except

return sys.maxsize

def linux_distribution(self):

@@ -171,9 +171,10 @@ class PlatformInfo(object):

return 'vista'

if win_version_tuple[:2] == (5, 1):

return 'xp'

- assert (win_version_tuple[0] > 10 or

- win_version_tuple[0] == 10 and win_version_tuple[1] > 0), (

- 'Unrecognized Windows version tuple: "%s"' % (win_version_tuple,))

+ assert (

+ win_version_tuple[0] > 10 or

+ win_version_tuple[0] == 10 and win_version_tuple[1] > 0), (

+ 'Unrecognized Windows version tuple: "%s"' % (win_version_tuple,))

return 'future'

def _win_version_tuple(self, sys_module):