Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25782002: Style fixes for cast_unittest to build (Closed)

Created:
7 years, 2 months ago by Alpha Left Google
Modified:
7 years, 2 months ago
Reviewers:
hubbe
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Style fixes for cast_unittest to build Relanding r226264 that includes a bunch of style fixes to cast code. R=hubbe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226538

Patch Set 1 #

Total comments: 10

Patch Set 2 : NOTREACHED() and removed static_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -197 lines) Patch
M media/cast/audio_receiver/audio_decoder.h View 3 chunks +7 lines, -5 lines 0 comments Download
M media/cast/audio_receiver/audio_decoder.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M media/cast/audio_receiver/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/audio_receiver/audio_receiver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/audio_sender/audio_encoder.h View 3 chunks +6 lines, -4 lines 0 comments Download
M media/cast/audio_sender/audio_encoder.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/cast/audio_sender/audio_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/audio_sender/audio_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast.gyp View 2 chunks +12 lines, -0 lines 0 comments Download
M media/cast/cast_config.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/cast/cast_config.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/cast_receiver.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/cast_receiver.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_sender.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/cast_sender.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_sender_impl.h View 1 chunk +2 lines, -7 lines 0 comments Download
M media/cast/cast_sender_impl.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M media/cast/cast_thread.h View 1 chunk +5 lines, -0 lines 0 comments Download
M media/cast/cast_thread.cc View 1 3 chunks +7 lines, -1 line 0 comments Download
M media/cast/congestion_control/congestion_control.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/congestion_control/congestion_control.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/cast/framer/cast_message_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/framer/frame_buffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/framer/framer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/pacing/mock_paced_packet_sender.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + media/cast/pacing/mock_paced_packet_sender.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M media/cast/pacing/mock_packet_sender.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + media/cast/pacing/mock_packet_sender.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M media/cast/pacing/paced_sender.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/cast/pacing/paced_sender.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/rtcp/mock_rtcp_receiver_feedback.h View 2 chunks +6 lines, -0 lines 0 comments Download
A media/cast/rtcp/mock_rtcp_receiver_feedback.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M media/cast/rtcp/mock_rtcp_sender_feedback.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + media/cast/rtcp/mock_rtcp_sender_feedback.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/rtcp/rtcp_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/rtcp/test_rtcp_packet_builder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/rtp_common/mock_rtp_payload_feedback.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + media/cast/rtp_common/mock_rtp_payload_feedback.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M media/cast/rtp_receiver/receiver_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/cast/rtp_receiver/rtp_parser/rtp_parser.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D media/cast/rtp_receiver/rtp_parser/rtp_parser.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/rtp_receiver/rtp_receiver.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + media/cast/rtp_sender/packet_storage/packet_storage.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
D media/cast/rtp_sender/packet_storage/packet_storage.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
A + media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
D media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
M media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_config.h View 1 chunk +1 line, -9 lines 0 comments Download
A media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_config.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M media/cast/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/rtp_sender/rtp_sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/rtp_sender/rtp_sender.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/video_receiver/video_decoder.h View 2 chunks +5 lines, -2 lines 0 comments Download
M media/cast/video_receiver/video_decoder_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 2 chunks +1 line, -5 lines 0 comments Download
M media/cast/video_receiver/video_receiver_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M media/cast/video_sender/mock_video_encoder_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
A media/cast/video_sender/mock_video_encoder_controller.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M media/cast/video_sender/video_encoder.h View 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/video_sender/video_encoder.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/video_sender/video_encoder_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
7 years, 2 months ago (2013-10-02 19:35:27 UTC) #1
hubbe
https://codereview.chromium.org/25782002/diff/1/media/cast/cast_thread.cc File media/cast/cast_thread.cc (right): https://codereview.chromium.org/25782002/diff/1/media/cast/cast_thread.cc#newcode63 media/cast/cast_thread.cc:63: CHECK(false) << "Invalid Thread ID."; In google3, LOG(FATAL) is ...
7 years, 2 months ago (2013-10-02 19:44:52 UTC) #2
Alpha Left Google
https://codereview.chromium.org/25782002/diff/1/media/cast/cast_thread.cc File media/cast/cast_thread.cc (right): https://codereview.chromium.org/25782002/diff/1/media/cast/cast_thread.cc#newcode63 media/cast/cast_thread.cc:63: CHECK(false) << "Invalid Thread ID."; Updated it to NOTREACHED(). ...
7 years, 2 months ago (2013-10-02 19:56:23 UTC) #3
hubbe
lgtm
7 years, 2 months ago (2013-10-02 19:57:42 UTC) #4
Alpha Left Google
7 years, 2 months ago (2013-10-02 19:59:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r226538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698