Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

Issue 2578173002: NTP: Extract JSON requests from Fetcher. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
index 2ad2080a3c4ee90076fabf9980fd8b1616a2dd3e..ab33074e73bf8764a149e3f582f3dd0023115e74 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
@@ -282,8 +282,8 @@ gfx::Image FetchImage(RemoteSuggestionsProvider* service,
void ParseJson(
const std::string& json,
- const ntp_snippets::NTPSnippetsFetcher::SuccessCallback& success_callback,
- const ntp_snippets::NTPSnippetsFetcher::ErrorCallback& error_callback) {
+ const internal::NTPSnippetsJsonRequest::SuccessCallback& success_callback,
+ const internal::NTPSnippetsJsonRequest::ErrorCallback& error_callback) {
base::JSONReader json_reader;
std::unique_ptr<base::Value> value = json_reader.ReadToValue(json);
if (value) {
@@ -457,8 +457,7 @@ class RemoteSuggestionsProviderTest : public ::testing::Test {
return base::MakeUnique<RemoteSuggestionsProvider>(
observer_.get(), &category_factory_, utils_.pref_service(), "fr",
&user_classifier_, &scheduler_, std::move(snippets_fetcher),
- std::move(image_fetcher), std::move(image_decoder),
- std::move(database),
+ std::move(image_fetcher), std::move(image_decoder), std::move(database),
base::MakeUnique<RemoteSuggestionsStatusService>(
utils_.fake_signin_manager(), utils_.pref_service()));
}

Powered by Google App Engine
This is Rietveld 408576698