NTP: Extract JSON requests from Fetcher.

chrome/browser/ui/webui/snippets_internals_message_handler.cc

Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc
index c32b36c4355fb5317082bdb2a46a42dcebaacfdd..d3aa887f8dfbf05c86d42d6ddc534beb028d9fd5 100644
--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc
@@ -303,14 +303,14 @@ void SnippetsInternalsMessageHandler::SendAllContent() {
   if (remote_suggestions_provider_) {
     switch (
         remote_suggestions_provider_->snippets_fetcher()->personalization()) {
-      case ntp_snippets::NTPSnippetsFetcher::Personalization::kPersonal:
+      case ntp_snippets::internal::Personalization::kPersonal:

[tschumann, 2016/12/16 16:36:20]

nit while we're here: The string should be produced inside the snippets fetcher
and then you don't have to worry about accessing members from the internal
namespace.
Given that this is (as it looks) the only place where we need to access this
member, we should change the method to return a string:
string NTPSnippetsFetcher::PersonalizationModeString()

Thinking more of it, we shouldn't get access to the fetcher here anyways, as
this data is read from the variations anyways.

A TODO() for now is fine -- possibly to move the VariationParameter parsing out
of the snippetsfetcher (in a function) so that we can access it here.

[fhorschig, 2016/12/20 10:07:38]

Fetcher creates the string.
TODO added.
Another TODO was added to the remotesuggestionsprovider. We only use 
|snippets_fetcher()| in snippets-internal/ and tests.
If we have a mock/fake, the provider tests shouldn't check the implementation of
the fetcher.

         SendString("switch-personalized", "Only personalized");
         break;
-      case ntp_snippets::NTPSnippetsFetcher::Personalization::kBoth:
+      case ntp_snippets::internal::Personalization::kBoth:
         SendString("switch-personalized",
                    "Both personalized and non-personalized");
         break;
-      case ntp_snippets::NTPSnippetsFetcher::Personalization::kNonPersonal:
+      case ntp_snippets::internal::Personalization::kNonPersonal:
         SendString("switch-personalized", "Only non-personalized");
         break;
     }