Chromium Code Reviews Chromium Code Reviews
Issue 2578143003:
CSS Transitions: Fix flaky test unprefixed-transform.html (Closed)
| Index: third_party/WebKit/LayoutTests/transitions/unprefixed-transform.html |
| diff --git a/third_party/WebKit/LayoutTests/transitions/unprefixed-transform.html b/third_party/WebKit/LayoutTests/transitions/unprefixed-transform.html |
| index f7eb93bff9f6c3a49733238aa0875abd2aad2869..31e46cc3bfb85004fc4f269a7cba594979e203d2 100644 |
| --- a/third_party/WebKit/LayoutTests/transitions/unprefixed-transform.html |
| +++ b/third_party/WebKit/LayoutTests/transitions/unprefixed-transform.html |
| @@ -1,36 +1,41 @@ |
| <!DOCTYPE html> |
| -<div class="target">-webkit-transform 10ms</div><br> |
| -<div class="target">transform 10ms</div><br> |
| -<div class="target">transform 10ms, -webkit-transform 10ms</div><br> |
| -<div class="target">-webkit-transform 10ms, transform 10ms</div><br> |
| -<div class="target">all 10ms</div><br> |
| -<div class="target">all 10ms, -webkit-transform 10ms</div><br> |
| -<div class="target">-webkit-transform 10ms, all 10ms</div> |
| +<meta charset="utf-8"> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<div id="container"></div> |
| <script> |
| -if (window.testRunner) { |
| - testRunner.dumpAsText(); |
| - testRunner.waitUntilDone(); |
| -} |
| +'use strict'; |
| -document.addEventListener('transitionend', function(e) { |
| - var result = document.createElement('div'); |
| - result.textContent = 'fired transitionend with propertyName: ' + e.propertyName; |
| - e.target.appendChild(result); |
| - if (window.testRunner) { |
| - // All events should be fired by next frame. |
| - requestAnimationFrame(function() { |
| - testRunner.notifyDone(); |
| +var transitionValues = [ |
| + '-webkit-transform 10ms', |
| + 'transform 10ms', |
| + 'transform 10ms, -webkit-transform 10ms', |
| + '-webkit-transform 10ms, transform 10ms', |
| + 'all 10ms', |
| + 'all 10ms, -webkit-transform 10ms', |
| + '-webkit-transform 10ms, all 10ms' |
| +]; |
| + |
| +async_test(t => { |
| + var remaining = transitionValues.length; |
| + document.addEventListener('transitionend', e => { |
| + t.step_func(() => { |
| + assert_equals(e.propertyName, 'transform'); |
|
suzyh_UTC10 (ex-contributor)
2016/12/18 23:47:27
Any other checks it would make sense to do on the
Eric Willigers
2016/12/19 06:04:37
Added a few more asserts on event properties.
|
| }); |
| - } |
| -}); |
| + remaining -= 1; |
| + if (!remaining) |
|
suzyh_UTC10 (ex-contributor)
2016/12/18 23:47:27
What happens if we don't get the wrong number of e
Eric Willigers
2016/12/19 06:04:37
Done, by waiting a short time so we can detect exc
|
| + t.done(); |
| + }); |
| -onload = function() { |
| - var targets = document.querySelectorAll('.target'); |
| - for (var i = 0; i < targets.length; i++) { |
| - targets[i].offsetTop; |
| - targets[i].style.transition = targets[i].textContent; |
| - targets[i].style.webkitTransform = 'rotate(360deg)'; |
| - targets[i].style.transform = 'rotate(360deg)'; |
| + for (let i = 0; i < transitionValues.length; i++) { |
| + const element = document.createElement('div'); |
| + container.appendChild(element); |
| + requestAnimationFrame(() => { |
| + element.offsetTop; |
| + element.style.transition = transitionValues[i]; |
| + element.style.webkitTransform = 'rotate(360deg)'; |
| + element.style.transform = 'rotate(360deg)'; |
| + }); |
| } |
| -}; |
| +}, 'transitionend event for unprefixed transform'); |
|
suzyh_UTC10 (ex-contributor)
2016/12/18 23:47:27
If this test is targeted at the unprefixed transfo
Eric Willigers
2016/12/19 06:04:37
No, the point of this test is that the page might
suzyh_UTC10 (ex-contributor)
2016/12/19 23:10:52
Ah, making sure that there's only one event makes
Eric Willigers
2016/12/20 01:06:15
Test description updated.
|
| </script> |
