Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: pkg/dev_compiler/lib/src/compiler/command.dart

Issue 2578113002: refactor DDC to support --ignore-unrecognized-flags (Closed)
Patch Set: merge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/lib/src/options.dart ('k') | pkg/dev_compiler/test/worker/worker_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/command.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/command.dart b/pkg/dev_compiler/lib/src/compiler/command.dart
index 8a4f92ab6fab09e7431a135ac7caa355b3f2c6ca..c3817877b5f45cab0935033c5cb12ba0673bc06d 100644
--- a/pkg/dev_compiler/lib/src/compiler/command.dart
+++ b/pkg/dev_compiler/lib/src/compiler/command.dart
@@ -4,7 +4,10 @@
import 'dart:io';
import 'package:analyzer/src/command_line/arguments.dart'
- show extractDefinedVariables;
+ show
+ extractDefinedVariables,
+ filterUnknownArguments,
+ ignoreUnrecognizedFlagsFlag;
import 'package:analyzer/src/generated/source.dart' show Source;
import 'package:analyzer/src/summary/package_bundle_reader.dart'
show InSummarySource;
@@ -29,7 +32,11 @@ int compile(List<String> args, {void printFn(Object obj)}) {
var declaredVars = <String, String>{};
try {
args = extractDefinedVariables(args, declaredVars);
- argResults = _argParser().parse(args);
+ var parser = _argParser();
+ if (args.contains('--$ignoreUnrecognizedFlagsFlag')) {
+ args = filterUnknownArguments(args, parser);
+ }
+ argResults = parser.parse(args);
_verbose = argResults['verbose'];
} on FormatException catch (error) {
printFn('$error\n\n$_usageMessage');
@@ -77,6 +84,10 @@ ArgParser _argParser({bool hide: true}) {
'Add --verbose to show hidden options.',
negatable: false)
..addFlag('verbose', abbr: 'v', help: 'Verbose output.')
+ ..addFlag(ignoreUnrecognizedFlagsFlag,
+ help: 'Ignore unrecognized command line flags.',
+ defaultsTo: false,
+ negatable: false)
..addOption('out',
abbr: 'o', allowMultiple: true, help: 'Output file (required).')
..addOption('module-root',
« no previous file with comments | « pkg/analyzer_cli/lib/src/options.dart ('k') | pkg/dev_compiler/test/worker/worker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698