Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: pkg/analyzer_cli/lib/src/options.dart

Issue 2578113002: refactor DDC to support --ignore-unrecognized-flags (Closed)
Patch Set: merge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/command_line/test_all.dart ('k') | pkg/dev_compiler/lib/src/compiler/command.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/options.dart
diff --git a/pkg/analyzer_cli/lib/src/options.dart b/pkg/analyzer_cli/lib/src/options.dart
index fae9672db8f26e815e892a6f0bf2b1e6b660f644..1cc485792dd290eb915b6863632cc36162b55036 100644
--- a/pkg/analyzer_cli/lib/src/options.dart
+++ b/pkg/analyzer_cli/lib/src/options.dart
@@ -8,7 +8,6 @@ import 'dart:io';
import 'package:analyzer/file_system/physical_file_system.dart';
import 'package:analyzer/src/command_line/arguments.dart';
-import 'package:analyzer/src/command_line/command_line_parser.dart';
import 'package:analyzer_cli/src/driver.dart';
import 'package:args/args.dart';
import 'package:cli_util/cli_util.dart' show getSdkDir;
@@ -282,7 +281,7 @@ class CommandLineOptions {
bool hide = !verbose;
args = args.expand((String arg) => arg.split('=')).toList();
- var parser = new CommandLineParser()
+ var parser = new ArgParser(allowTrailingOptions: true)
..addFlag('batch',
abbr: 'b',
help: 'Read commands from standard input (for testing).',
@@ -318,6 +317,10 @@ class CommandLineOptions {
defaultsTo: false,
negatable: false)
..addFlag('disable-cache-flushing', defaultsTo: false, hide: true)
+ ..addFlag(ignoreUnrecognizedFlagsFlag,
+ help: 'Ignore unrecognized command line flags.',
+ defaultsTo: false,
+ negatable: false)
..addFlag('fatal-hints',
help: 'Treat hints as fatal.', defaultsTo: false, negatable: false)
..addFlag('fatal-warnings',
@@ -489,6 +492,9 @@ class CommandLineOptions {
args.map((String arg) => arg == '-batch' ? '--batch' : arg).toList();
Map<String, String> definedVariables = <String, String>{};
args = extractDefinedVariables(args, definedVariables);
+ if (args.contains('--$ignoreUnrecognizedFlagsFlag')) {
+ args = filterUnknownArguments(args, parser);
+ }
var results = parser.parse(args);
// Persistent worker.
« no previous file with comments | « pkg/analyzer/test/src/command_line/test_all.dart ('k') | pkg/dev_compiler/lib/src/compiler/command.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698