Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 2578113002: refactor DDC to support --ignore-unrecognized-flags (Closed)

Created:
4 years ago by danrubel
Modified:
4 years ago
Reviewers:
vsm, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

refactor DDC to support --ignore-unrecognized-flags * add --ignore-unrecognized-flags to DDC * refactor Analyzer CLI to use same filterUnknownArguments functionality * remove now unused CommandLineParser and associated tests R=brianwilkerson@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/5b846118560ef8bdfc08f834dcf6ef0fe8b4b194

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -213 lines) Patch
M pkg/analyzer/lib/src/command_line/arguments.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D pkg/analyzer/lib/src/command_line/command_line_parser.dart View 1 chunk +0 lines, -127 lines 0 comments Download
M pkg/analyzer/test/src/command_line/arguments_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
D pkg/analyzer/test/src/command_line/command_line_parser_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M pkg/analyzer/test/src/command_line/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 4 chunks +8 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/command.dart View 3 chunks +13 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/worker/worker_test.dart View 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
4 years ago (2016-12-15 13:39:17 UTC) #2
Brian Wilkerson
Fantastic! Thanks! lgtm
4 years ago (2016-12-15 15:05:42 UTC) #3
vsm
lgtm
4 years ago (2016-12-15 15:23:37 UTC) #4
danrubel
4 years ago (2016-12-15 15:46:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5b846118560ef8bdfc08f834dcf6ef0fe8b4b194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698