Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.cpp

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.cpp b/tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.cpp
index 382e9f9739283d27ab03e0f609e62b2b85ce2d62..db9d53515b7d48008dc30ad8b719577b1c9bb7f3 100644
--- a/tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.cpp
+++ b/tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.cpp
@@ -6,23 +6,23 @@
namespace blink {
-void HeapObject::trace(Visitor* visitor)
+void HeapObject::Trace(Visitor* visitor)
{
- // Missing visitor->trace(m_obj1);
- // Missing visitor->trace(m_obj2);
- // visitor->trace(m_obj3) in callback.
- // Missing visitor->trace(m_set1);
- visitor->trace(m_set2);
- visitor->registerWeakMembers<HeapObject,
+ // Missing visitor->Trace(m_obj1);
+ // Missing visitor->Trace(m_obj2);
+ // visitor->Trace(m_obj3) in callback.
+ // Missing visitor->Trace(m_set1);
+ visitor->Trace(m_set2);
+ visitor->RegisterWeakMembers<HeapObject,
&HeapObject::clearWeakMembers>(this);
}
void HeapObject::clearWeakMembers(Visitor* visitor)
{
- visitor->trace(m_obj1); // Does not count.
- // Missing visitor->trace(m_obj2);
- visitor->trace(m_obj3); // OK.
- visitor->trace(m_set1); // Does not count.
+ visitor->Trace(m_obj1); // Does not count.
+ // Missing visitor->Trace(m_obj2);
+ visitor->Trace(m_obj3); // OK.
+ visitor->Trace(m_set1); // Does not count.
}
}

Powered by Google App Engine
This is Rietveld 408576698