tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp ('k') | tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

diff --git a/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt b/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

index fb466967a3350a8292e6e576f31dfdeda53e330e..7a54b97bf0dd0fa230ec9bed5a976521945b06af 100644

--- a/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

+++ b/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

@@ -5,7 +5,7 @@ class A : public GarbageCollected<A> {

./virtual_and_trace_after_dispatch.h:23:1: warning: [blink-gc] Class 'B' contains or inherits virtual methods but implements manual dispatching.

class B : public A {

-./virtual_and_trace_after_dispatch.h:14:5: note: [blink-gc] Manual dispatch 'trace' declared here:

- void trace(Visitor*);

+./virtual_and_trace_after_dispatch.h:14:5: note: [blink-gc] Manual dispatch 'Trace' declared here:

+ void Trace(Visitor*);

2 warnings generated.