Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_error.h

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_error.h
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_error.h b/tools/clang/blink_gc_plugin/tests/traceimpl_error.h
index 5a883b4e56261467156cab1c1520e224eb9d5398..c7254d44f15476ee27d85cfc5e5e4f14682f1d87 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_error.h
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_error.h
@@ -11,16 +11,16 @@ namespace blink {
class X : public GarbageCollected<X> {
public:
- virtual void trace(Visitor*) {}
+ virtual void Trace(Visitor*) {}
};
class TraceImplInlinedWithUntracedMember
: public GarbageCollected<TraceImplInlinedWithUntracedMember> {
public:
- void trace(Visitor* visitor) { traceImpl(visitor); }
+ void Trace(Visitor* visitor) { TraceImpl(visitor); }
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
+ void TraceImpl(VisitorDispatcher visitor) {
// Empty; should get complaints from the plugin for untraced x_.
}
@@ -31,10 +31,10 @@ class TraceImplInlinedWithUntracedMember
class TraceImplExternWithUntracedMember
: public GarbageCollected<TraceImplExternWithUntracedMember> {
public:
- void trace(Visitor* visitor);
+ void Trace(Visitor* visitor);
template <typename VisitorDispatcher>
- inline void traceImpl(VisitorDispatcher);
+ inline void TraceImpl(VisitorDispatcher);
private:
Member<X> x_;
@@ -42,25 +42,25 @@ class TraceImplExternWithUntracedMember
class Base : public GarbageCollected<Base> {
public:
- virtual void trace(Visitor*) {}
+ virtual void Trace(Visitor*) {}
};
class TraceImplInlineWithUntracedBase : public Base {
public:
- void trace(Visitor* visitor) override { traceImpl(visitor); }
+ void Trace(Visitor* visitor) override { TraceImpl(visitor); }
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
+ void TraceImpl(VisitorDispatcher visitor) {
// Empty; should get complaints from the plugin for untraced Base.
}
};
class TraceImplExternWithUntracedBase : public Base {
public:
- void trace(Visitor*) override;
+ void Trace(Visitor*) override;
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor);
+ void TraceImpl(VisitorDispatcher visitor);
};
}

Powered by Google App Engine
This is Rietveld 408576698