tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/persistent_no_trace.txt ('k') | tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h

diff --git a/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h

index f5d999ebf6430a7eddc20c549c268f6c36b5143d..7221280e9a890590da7db4a307c8c1fa4677c912 100644

--- a/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h

+++ b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h

@@ -11,7 +11,7 @@ namespace blink {

class HeapObject : public GarbageCollected<HeapObject> {

public:

- void trace(Visitor*) { }

+ void Trace(Visitor*) { }

};

class NonPolymorphicBase {

@@ -26,7 +26,7 @@ class IsLeftMostPolymorphic

: public GarbageCollected<IsLeftMostPolymorphic>,

public PolymorphicBase {

public:

- void trace(Visitor*);

+ void Trace(Visitor*);

private:

Member<HeapObject> m_obj;

};

@@ -36,7 +36,7 @@ class IsNotLeftMostPolymorphic

public NonPolymorphicBase,

public PolymorphicBase {

public:

- void trace(Visitor*);

+ void Trace(Visitor*);

private:

Member<HeapObject> m_obj;

};

@@ -45,7 +45,7 @@ template<typename T>

class TemplatedNonPolymorphicBase

: public GarbageCollected<TemplatedNonPolymorphicBase<T> > {

public:

- void trace(Visitor* visitor) { visitor->trace(m_obj); }

+ void Trace(Visitor* visitor) { visitor->Trace(m_obj); }

private:

Member<HeapObject> m_obj;

};