tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.cpp ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_eagerly_finalized.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt

diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt b/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt

new file mode 100644

index 0000000000000000000000000000000000000000..0470b51a3c7d63966b1de7e181c11799b23ffb7c

--- /dev/null

+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt

@@ -0,0 +1,19 @@

+destructor_access_finalized_field.cpp:18:9: warning: [blink-gc] Finalizer '~HeapObject' accesses potentially finalized field 'm_obj'.

+ bar(m_obj);

+ ^

+./destructor_access_finalized_field.h:38:5: note: [blink-gc] Potentially finalized field 'm_obj' declared here:

+ Member<HeapObject> m_obj;

+ ^

+destructor_access_finalized_field.cpp:19:5: warning: [blink-gc] Finalizer '~HeapObject' accesses potentially finalized field 'm_obj'.

+ m_obj->foo();

+ ^

+./destructor_access_finalized_field.h:38:5: note: [blink-gc] Potentially finalized field 'm_obj' declared here:

+ Member<HeapObject> m_obj;

+ ^

+destructor_access_finalized_field.cpp:20:5: warning: [blink-gc] Finalizer '~HeapObject' accesses potentially finalized field 'm_objs'.

+ m_objs[0];

+ ^

+./destructor_access_finalized_field.h:39:5: note: [blink-gc] Potentially finalized field 'm_objs' declared here:

+ Vector<Member<HeapObject> > m_objs;

+ ^

+3 warnings generated.