tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp b/tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp

index 87559a85c8c3e58959d882ac4f3364e7e30b96cb..474be5188c054e1690029d79b1a8b423b327e577 100644

--- a/tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp

+++ b/tools/clang/blink_gc_plugin/tests/base_requires_tracing.cpp

@@ -6,16 +6,16 @@

namespace blink {

-void A::trace(Visitor* visitor) { }

+void A::Trace(Visitor* visitor) { }

-void C::trace(Visitor* visitor) {

- visitor->trace(m_a);

+void C::Trace(Visitor* visitor) {

+ visitor->Trace(m_a);

// Missing B::trace(visitor)

}

-void D::trace(Visitor* visitor) {

- visitor->trace(m_a);

- C::trace(visitor);

+void D::Trace(Visitor* visitor) {

+ visitor->Trace(m_a);

+ C::Trace(visitor);

}