Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1702)

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
index d60d73f9d6b89f4970256e64440e484b740f04e8..107c7252e3ec4a1cd04642f69792b54cf488bcfc 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
@@ -23,19 +23,21 @@ class BlinkGCPluginAction : public PluginASTAction {
protected:
// Overridden from PluginASTAction:
- virtual std::unique_ptr<ASTConsumer> CreateASTConsumer(
+ std::unique_ptr<ASTConsumer> CreateASTConsumer(
CompilerInstance& instance,
- llvm::StringRef ref) {
+ llvm::StringRef ref) override {
return llvm::make_unique<BlinkGCPluginConsumer>(instance, options_);
}
- virtual bool ParseArgs(const CompilerInstance&,
- const std::vector<std::string>& args) {
+ bool ParseArgs(const CompilerInstance&,
+ const std::vector<std::string>& args) override {
sof 2016/12/16 07:55:55 Quirky formatting.
for (const auto& arg : args) {
if (arg == "dump-graph") {
options_.dump_graph = true;
} else if (arg == "warn-unneeded-finalizer") {
options_.warn_unneeded_finalizer = true;
+ } else if (arg == "use-chromium-style-naming") {
+ options_.use_chromium_style_naming = true;
} else {
llvm::errs() << "Unknown blink-gc-plugin argument: " << arg << "\n";
return false;
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | tools/clang/blink_gc_plugin/Config.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698