tools/clang/blink_gc_plugin/tests/legacy_naming/trace_collections.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/trace_collections.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/trace_collections.cpp ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/trace_if_needed.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 trace_collections.cpp:9:1: warning: [blink-gc] Class 'HeapObject' has untraced f ields that require tracing.	1 trace_collections.cpp:9:1: warning: [blink-gc] Class 'HeapObject' has untraced f ields that require tracing.

2 void HeapObject::trace(Visitor* visitor)	2 void HeapObject::trace(Visitor* visitor)

3 ^	3 ^

4 ./trace_collections.h:16:5: note: [blink-gc] Untraced field 'm_heapVector' decla red here:	4 ./trace_collections.h:16:5: note: [blink-gc] Untraced field 'm_heapVector' decla red here:

5 HeapVector<Member<HeapObject> > m_heapVector;	5 HeapVector<Member<HeapObject> > m_heapVector;

6 ^	6 ^

7 ./trace_collections.h:17:5: note: [blink-gc] Untraced field 'm_wtfVector' declar ed here:	7 ./trace_collections.h:17:5: note: [blink-gc] Untraced field 'm_wtfVector' declar ed here:

8 Vector<Member<HeapObject>, 0, HeapAllocator> m_wtfVector;	8 Vector<Member<HeapObject>, 0, HeapAllocator> m_wtfVector;

9 ^	9 ^

10 ./trace_collections.h:19:5: note: [blink-gc] Untraced field 'm_heapDeque' declar ed here:	10 ./trace_collections.h:19:5: note: [blink-gc] Untraced field 'm_heapDeque' declar ed here:

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 ./trace_collections.h:35:5: note: [blink-gc] Untraced field 'm_heapMapVal' decla red here:	43 ./trace_collections.h:35:5: note: [blink-gc] Untraced field 'm_heapMapVal' decla red here:

44 HeapHashMap<Member<HeapObject>, int > m_heapMapVal;	44 HeapHashMap<Member<HeapObject>, int > m_heapMapVal;

45 ^	45 ^

46 ./trace_collections.h:36:5: note: [blink-gc] Untraced field 'm_wtfMapKey' declar ed here:	46 ./trace_collections.h:36:5: note: [blink-gc] Untraced field 'm_wtfMapKey' declar ed here:

47 HashMap<int, Member<HeapObject>, void, void, void, HeapAllocator>	47 HashMap<int, Member<HeapObject>, void, void, void, HeapAllocator>

48 ^	48 ^

49 ./trace_collections.h:38:5: note: [blink-gc] Untraced field 'm_wtfMapVal' declar ed here:	49 ./trace_collections.h:38:5: note: [blink-gc] Untraced field 'm_wtfMapVal' declar ed here:

50 HashMap<Member<HeapObject>, int, void, void, void, HeapAllocator>	50 HashMap<Member<HeapObject>, int, void, void, void, HeapAllocator>

51 ^	51 ^

52 1 warning generated.	52 1 warning generated.

OLD	NEW