tools/clang/blink_gc_plugin/tests/legacy_naming/non_virtual_trace.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/non_virtual_trace.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/non_virtual_trace.cpp ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/own_ptr_to_gc_managed_class.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from non_virtual_trace.cpp:5:	1 In file included from non_virtual_trace.cpp:5:

2 ./non_virtual_trace.h:12:1: warning: [blink-gc] Left-most base class 'A' of deri ved class 'D' must define a virtual trace method.	2 ./non_virtual_trace.h:12:1: warning: [blink-gc] Left-most base class 'A' of deri ved class 'D' must define a virtual trace method.

3 class A : public GarbageCollected<A> {	3 class A : public GarbageCollected<A> {

4 ^	4 ^

5 non_virtual_trace.cpp:13:1: warning: [blink-gc] Class 'C' overrides non-virtual trace of base class 'A'.	5 non_virtual_trace.cpp:13:1: warning: [blink-gc] Class 'C' overrides non-virtual trace of base class 'A'.

6 void C::trace(Visitor* visitor)	6 void C::trace(Visitor* visitor)

7 ^	7 ^

8 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:	8 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:

9 void trace(Visitor*);	9 void trace(Visitor*);

10 ^	10 ^

11 non_virtual_trace.cpp:18:1: warning: [blink-gc] Class 'D' overrides non-virtual trace of base class 'A'.	11 non_virtual_trace.cpp:18:1: warning: [blink-gc] Class 'D' overrides non-virtual trace of base class 'A'.

12 void D::trace(Visitor* visitor)	12 void D::trace(Visitor* visitor)

13 ^	13 ^

14 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:	14 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:

15 void trace(Visitor*);	15 void trace(Visitor*);

16 ^	16 ^

17 3 warnings generated.	17 3 warnings generated.

OLD	NEW