tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.cpp ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/garbage_collected_mixin.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from finalize_after_dispatch.cpp:5:	1 In file included from finalize_after_dispatch.cpp:5:

2 ./finalize_after_dispatch.h:12:1: warning: [blink-gc] Class 'NeedsFinalize' is m issing manual finalize dispatch.	2 ./finalize_after_dispatch.h:12:1: warning: [blink-gc] Class 'NeedsFinalize' is m issing manual finalize dispatch.

3 class NeedsFinalize : public GarbageCollectedFinalized<NeedsFinalize> {	3 class NeedsFinalize : public GarbageCollectedFinalized<NeedsFinalize> {

4 ^	4 ^

5 ./finalize_after_dispatch.h:19:1: warning: [blink-gc] Class 'NeedsDispatch' is m issing manual trace dispatch.	5 ./finalize_after_dispatch.h:19:1: warning: [blink-gc] Class 'NeedsDispatch' is m issing manual trace dispatch.

6 class NeedsDispatch : public GarbageCollectedFinalized<NeedsDispatch> {	6 class NeedsDispatch : public GarbageCollectedFinalized<NeedsDispatch> {

7 ^	7 ^

8 ./finalize_after_dispatch.h:26:1: warning: [blink-gc] Class 'NeedsFinalizedBase' requires finalization.	8 ./finalize_after_dispatch.h:26:1: warning: [blink-gc] Class 'NeedsFinalizedBase' requires finalization.

9 class NeedsFinalizedBase : public GarbageCollected<NeedsFinalizedBase> {	9 class NeedsFinalizedBase : public GarbageCollected<NeedsFinalizedBase> {

10 ^	10 ^

11 ./finalize_after_dispatch.h:30:5: note: [blink-gc] User-declared finalizer decla red here:	11 ./finalize_after_dispatch.h:30:5: note: [blink-gc] User-declared finalizer decla red here:

12 void finalizeGarbageCollectedObject() { };	12 void finalizeGarbageCollectedObject() { };

13 ^	13 ^

14 finalize_after_dispatch.cpp:30:1: warning: [blink-gc] Missing dispatch to class 'D' in manual finalize dispatch.	14 finalize_after_dispatch.cpp:30:1: warning: [blink-gc] Missing dispatch to class 'D' in manual finalize dispatch.

15 void A::finalizeGarbageCollectedObject()	15 void A::finalizeGarbageCollectedObject()

16 ^	16 ^

17 4 warnings generated.	17 4 warnings generated.

OLD	NEW