tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.cpp ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 fields_require_tracing.cpp:9:1: warning: [blink-gc] Class 'PartObject' has untra ced fields that require tracing.	1 fields_require_tracing.cpp:9:1: warning: [blink-gc] Class 'PartObject' has untra ced fields that require tracing.

2 void PartObject::trace(Visitor* visitor) {	2 void PartObject::trace(Visitor* visitor) {

3 ^	3 ^

4 ./fields_require_tracing.h:29:5: note: [blink-gc] Untraced field 'm_obj1' declar ed here:	4 ./fields_require_tracing.h:29:5: note: [blink-gc] Untraced field 'm_obj1' declar ed here:

5 Member<HeapObject> m_obj1;	5 Member<HeapObject> m_obj1;

6 ^	6 ^

7 ./fields_require_tracing.h:31:5: note: [blink-gc] Untraced field 'm_obj3' declar ed here:	7 ./fields_require_tracing.h:31:5: note: [blink-gc] Untraced field 'm_obj3' declar ed here:

8 Member<HeapObject> m_obj3;	8 Member<HeapObject> m_obj3;

9 ^	9 ^

10 fields_require_tracing.cpp:16:1: warning: [blink-gc] Class 'PartBObject' has unt raced fields that require tracing.	10 fields_require_tracing.cpp:16:1: warning: [blink-gc] Class 'PartBObject' has unt raced fields that require tracing.

11 void PartBObject::trace(Visitor* visitor) {	11 void PartBObject::trace(Visitor* visitor) {

12 ^	12 ^

13 ./fields_require_tracing.h:20:5: note: [blink-gc] Untraced field 'm_set' declare d here:	13 ./fields_require_tracing.h:20:5: note: [blink-gc] Untraced field 'm_set' declare d here:

14 HeapHashSet<PartBObject> m_set;	14 HeapHashSet<PartBObject> m_set;

15 ^	15 ^

16 fields_require_tracing.cpp:21:1: warning: [blink-gc] Class 'HeapObject' has untr aced fields that require tracing.	16 fields_require_tracing.cpp:21:1: warning: [blink-gc] Class 'HeapObject' has untr aced fields that require tracing.

17 void HeapObject::trace(Visitor* visitor) {	17 void HeapObject::trace(Visitor* visitor) {

18 ^	18 ^

19 ./fields_require_tracing.h:40:5: note: [blink-gc] Untraced field 'm_part' declar ed here:	19 ./fields_require_tracing.h:40:5: note: [blink-gc] Untraced field 'm_part' declar ed here:

20 PartObject m_part;	20 PartObject m_part;

21 ^	21 ^

22 3 warnings generated.	22 3 warnings generated.

OLD	NEW