tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.cpp ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from fields_illegal_tracing.cpp:5:	1 In file included from fields_illegal_tracing.cpp:5:

2 ./fields_illegal_tracing.h:32:1: warning: [blink-gc] Class 'PartObject' contains invalid fields.	2 ./fields_illegal_tracing.h:32:1: warning: [blink-gc] Class 'PartObject' contains invalid fields.

3 class PartObject {	3 class PartObject {

4 ^	4 ^

5 ./fields_illegal_tracing.h:37:5: note: [blink-gc] OwnPtr field 'm_obj1' to a GC managed class declared here:	5 ./fields_illegal_tracing.h:37:5: note: [blink-gc] OwnPtr field 'm_obj1' to a GC managed class declared here:

6 OwnPtr<HeapObject> m_obj1;	6 OwnPtr<HeapObject> m_obj1;

7 ^	7 ^

8 ./fields_illegal_tracing.h:38:5: note: [blink-gc] RefPtr field 'm_obj2' to a GC managed class declared here:	8 ./fields_illegal_tracing.h:38:5: note: [blink-gc] RefPtr field 'm_obj2' to a GC managed class declared here:

9 RefPtr<HeapObject> m_obj2;	9 RefPtr<HeapObject> m_obj2;

10 ^	10 ^

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 ./fields_illegal_tracing.h:52:5: note: [blink-gc] Untraceable field 'm_obj2' dec lared here:	59 ./fields_illegal_tracing.h:52:5: note: [blink-gc] Untraceable field 'm_obj2' dec lared here:

60 RefPtr<HeapObject> m_obj2;	60 RefPtr<HeapObject> m_obj2;

61 ^	61 ^

62 ./fields_illegal_tracing.h:54:5: note: [blink-gc] Untraceable field 'm_obj4' dec lared here:	62 ./fields_illegal_tracing.h:54:5: note: [blink-gc] Untraceable field 'm_obj4' dec lared here:

63 std::unique_ptr<HeapObject> m_obj4;	63 std::unique_ptr<HeapObject> m_obj4;

64 ^	64 ^

65 ./fields_illegal_tracing.h:57:5: note: [blink-gc] Untraced field 'm_iterator5' d eclared here:	65 ./fields_illegal_tracing.h:57:5: note: [blink-gc] Untraced field 'm_iterator5' d eclared here:

66 HeapListHashSet<Member<HeapObject>>::const_iterator m_iterator5;	66 HeapListHashSet<Member<HeapObject>>::const_iterator m_iterator5;

67 ^	67 ^

68 4 warnings generated.	68 4 warnings generated.

OLD	NEW