tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.txt - Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.txt

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)

Patch Set: Rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 garbage_collected_mixin.cpp:9:1: warning: [blink-gc] Class 'Mixin' has untraced fields that require tracing.	1 garbage_collected_mixin.cpp:9:1: warning: [blink-gc] Class 'Mixin' has untraced fields that require tracing.

2 void Mixin::trace(Visitor* visitor)	2 void Mixin::Trace(Visitor* visitor)

3 ^	3 ^

4 ./garbage_collected_mixin.h:16:5: note: [blink-gc] Untraced field 'm_self' decla red here:	4 ./garbage_collected_mixin.h:16:5: note: [blink-gc] Untraced field 'm_self' decla red here:

5 Member<Mixin> m_self;	5 Member<Mixin> m_self;

6 ^	6 ^

7 garbage_collected_mixin.cpp:14:1: warning: [blink-gc] Base class 'Mixin' of deri ved class 'HeapObject' requires tracing.	7 garbage_collected_mixin.cpp:14:1: warning: [blink-gc] Base class 'Mixin' of deri ved class 'HeapObject' requires tracing.

8 void HeapObject::trace(Visitor* visitor)	8 void HeapObject::Trace(Visitor* visitor)

9 ^	9 ^

10 2 warnings generated.	10 2 warnings generated.

OLD	NEW