Add use-chromium-style-naming option to Blink GC plugin.

tools/clang/blink_gc_plugin/Config.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines the names used by GC infrastructure.
 
 // TODO: Restructure the name determination to use fully qualified names (ala,
 // blink::Foo) so that the plugin can be enabled for all of chromium. Doing so
 // would allow us to catch errors with structures outside of blink that might
 // have unsafe pointers to GC allocated blink structures.
 
 #ifndef TOOLS_BLINK_GC_PLUGIN_CONFIG_H_
 #define TOOLS_BLINK_GC_PLUGIN_CONFIG_H_
 
 #include <cassert>
 
 #include "clang/AST/AST.h"
 #include "clang/AST/Attr.h"
 
-const char kNewOperatorName[] = "operator new";
-const char kCreateName[] = "create";
-const char kTraceName[] = "trace";
-const char kTraceImplName[] = "traceImpl";
-const char kFinalizeName[] = "finalizeGarbageCollectedObject";
-const char kTraceAfterDispatchName[] = "traceAfterDispatch";
-const char kTraceAfterDispatchImplName[] = "traceAfterDispatchImpl";
-const char kRegisterWeakMembersName[] = "registerWeakMembers";
-const char kHeapAllocatorName[] = "HeapAllocator";
-const char kTraceIfNeededName[] = "TraceIfNeeded";
-const char kVisitorDispatcherName[] = "VisitorDispatcher";
-const char kVisitorVarName[] = "visitor";
-const char kAdjustAndMarkName[] = "adjustAndMark";
-const char kIsHeapObjectAliveName[] = "isHeapObjectAlive";
-const char kIsEagerlyFinalizedName[] = "IsEagerlyFinalizedMarker";
+extern const char kNewOperatorName[];
+extern const char* kCreateName;

[dcheng, 2016/12/16 01:40:22]

This is horrible, but this is just temporary code that we'll remove once we
default this option to on.

+extern const char* kTraceName;
+extern const char* kTraceImplName;
+extern const char* kFinalizeName;
+extern const char* kTraceAfterDispatchName;
+extern const char* kTraceAfterDispatchImplName;
+extern const char* kRegisterWeakMembersName;
+extern const char kHeapAllocatorName[];
+extern const char kTraceIfNeededName[];
+extern const char kVisitorDispatcherName[];
+extern const char kVisitorVarName[];
+extern const char* kAdjustAndMarkName;
+extern const char* kIsHeapObjectAliveName;
+extern const char kIsEagerlyFinalizedName[];
 
 class Config {
  public:
+  static void UseLegacyNames();
+
   static bool IsMember(const std::string& name) {
     return name == "Member";
   }
 
   static bool IsWeakMember(const std::string& name) {
     return name == "WeakMember";
   }
 
   static bool IsMemberHandle(const std::string& name) {
     return IsMember(name) ||
@@ skipping 202 matching lines @@
     if (suffix.size() > str.size())
       return false;
     return str.compare(str.size() - suffix.size(), suffix.size(), suffix) == 0;
   }
 
   // Test if a template specialization is an instantiation.
   static bool IsTemplateInstantiation(clang::CXXRecordDecl* record);
 };
 
 #endif  // TOOLS_BLINK_GC_PLUGIN_CONFIG_H_