Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 257803013: Fix a value of EntryChangedKind that is dispatched when zipping completes. (Closed)

Created:
6 years, 7 months ago by hirono
Modified:
6 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Fix a value of EntryChangedKind that is dispatched when zipping completes. Previously the name of the enum value was wrong. This CL fixes it: EntryChangedKind.CREATE -> EntryChangedKind.CREATED. BUG=364258 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266562

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 chunk +31 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 7 months ago (2014-04-28 10:10:54 UTC) #1
yoshiki
lgtm
6 years, 7 months ago (2014-04-28 10:16:14 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 7 months ago (2014-04-28 10:16:24 UTC) #3
hirono
On 2014/04/28 10:16:14, yoshiki wrote: > lgtm Thank you!
6 years, 7 months ago (2014-04-28 10:16:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/257803013/20001
6 years, 7 months ago (2014-04-28 10:17:07 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:39:58 UTC) #6
Message was sent while issue was closed.
Change committed as 266562

Powered by Google App Engine
This is Rietveld 408576698