Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 257803012: Make escape analysis preserve all representations required by HCompareNumericAndBranch. (Closed)

Created:
6 years, 7 months ago by Jarin
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Make escape analysis preserve all representations required by HCompareNumericAndBranch. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/hydrogen-escape-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-escape-preserve-smi-representation.js View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
6 years, 7 months ago (2014-04-28 08:42:40 UTC) #1
Jarin
On 2014/04/28 08:42:40, jarin wrote: ping.
6 years, 7 months ago (2014-05-07 11:00:01 UTC) #2
Michael Starzinger
LGTM (sorry for delay).
6 years, 7 months ago (2014-05-08 08:45:07 UTC) #3
Jarin
6 years, 7 months ago (2014-05-12 08:43:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698