Source/bindings/v8/V8WindowShell.cpp - Issue 257803006: Fixing wrong extension ID in Activity Log entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 257803006: Fixing wrong extension ID in Activity Log entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ActivityLogger moved to ScriptState Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/V8DOMActivityLogger.cpp ('K') | « Source/bindings/v8/V8DOMActivityLogger.cpp ('k') | Source/web/WebDOMActivityLogger.cpp » ('j') | public/web/WebDOMActivityLogger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8WindowShell.cpp

diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp

index 9209dba2114ec1c60c1452f0136bfcf123d8f440..6aa0dd4bfcfcfa26d4678329791bcc2a18928c7a 100644

--- a/Source/bindings/v8/V8WindowShell.cpp

+++ b/Source/bindings/v8/V8WindowShell.cpp

@@ -216,7 +216,8 @@ bool V8WindowShell::initialize()

setInjectedScriptContextDebugId(context, m_frame->script().contextDebugId(mainWindow->context()));

}

- m_scriptState->world().setActivityLogger(V8DOMActivityLogger::activityLogger(m_world->worldId()));

+ m_scriptState->setActivityLogger(V8DOMActivityLogger::activityLogger(m_world->worldId(),

+ m_frame->document() ? m_frame->document()->baseURI() : KURL()));

if (!installDOMWindow()) {

disposeContext(DoNotDetachGlobal);

return false;

« Source/bindings/v8/V8DOMActivityLogger.cpp ('K') | « Source/bindings/v8/V8DOMActivityLogger.cpp ('k') | Source/web/WebDOMActivityLogger.cpp » ('j') | public/web/WebDOMActivityLogger.h » ('J')