Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: public/web/WebDOMActivityLogger.h

Issue 257803006: Fixing wrong extension ID in Activity Log entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: bug fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebDOMActivityLogger.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebDOMActivityLogger.h
diff --git a/public/web/WebDOMActivityLogger.h b/public/web/WebDOMActivityLogger.h
index a2955ee104993f07bb6233afcb09850860fe7300..4359ee7b2fd40d73b11043f7a113846ded4aa94c 100644
--- a/public/web/WebDOMActivityLogger.h
+++ b/public/web/WebDOMActivityLogger.h
@@ -48,12 +48,20 @@ public:
virtual void logMethod(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebURL& url, const WebString& title) { }
};
-// Checks if a logger already exists for the world identified
-// by worldId (worldId may be 0 identifying the main world).
-BLINK_EXPORT bool hasDOMActivityLogger(int worldId);
+// Checks if a logger already exists for the world identified by worldId and
+// extensionID (worldId may be 0 identifying the main world). Extension ID is
+// used only in the case of main world and ignored otherwise.
+BLINK_EXPORT bool hasDOMActivityLogger(int worldId, const WebString& extensionId);
+
+// Checks if the provided logger is non-null and if so associates it with the
+// world identified by worldId and extension ID (worldId may be 0 identifying
+// the main world). The extension ID is ignored for other worlds than the main
+// one.
+BLINK_EXPORT void setDOMActivityLogger(int worldId, const WebString& extensionId, WebDOMActivityLogger*);
-// Checks if the provided logger is non-null and if so associates it
-// with the world identified by worldId (worldId may be 0 identifying the main world).
+// FIXME: remove the following two methods after modifying Chrome to use the
+// above ones.
+BLINK_EXPORT bool hasDOMActivityLogger(int worldId);
BLINK_EXPORT void setDOMActivityLogger(int worldId, WebDOMActivityLogger*);
} // namespace blink
« no previous file with comments | « Source/web/WebDOMActivityLogger.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698