Fixing wrong extension ID in Activity Log entries.

Source/bindings/v8/V8WindowShell.cpp

Index: Source/bindings/v8/V8WindowShell.cpp
diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp
index 9209dba2114ec1c60c1452f0136bfcf123d8f440..6cdc7a88fa9e7f0376d2c946671b6570337195f0 100644
--- a/Source/bindings/v8/V8WindowShell.cpp
+++ b/Source/bindings/v8/V8WindowShell.cpp
@@ -216,7 +216,8 @@ bool V8WindowShell::initialize()
             setInjectedScriptContextDebugId(context, m_frame->script().contextDebugId(mainWindow->context()));
     }
 
-    m_scriptState->world().setActivityLogger(V8DOMActivityLogger::activityLogger(m_world->worldId()));
+    m_scriptState->perContextData()->setActivityLogger(V8DOMActivityLogger::activityLogger(
+        m_world->worldId(), m_frame->document() ? m_frame->document()->baseURI() : KURL()));

[haraken, 2014/05/08 23:47:45]

Shall we simply give up setting up the activity logger when we cannot get
m_frame->document()? Not setting up the activity logger would be better than
setting up the activity logger on an unexpected context.

[pmarch, 2014/05/09 14:53:52]

V8DOMActivityLogger::activityLogger() will return 0 when m_frame->document() ==
0 as there is no ActivityLogger set for an empty KURL(). The same will happen if
m_frame->document()->baseURI() is 0 or any non-extension URL.

However, if you think it will be better, I can wrap this line within 

if (m_frame->document() &&  m_frame->document()->baseURI().isEmpty()) {}

[haraken, 2014/05/09 14:56:07]

Thanks for the clarification. Then the current CL makes sense to me :)

     if (!installDOMWindow()) {
         disposeContext(DoNotDetachGlobal);
         return false;