Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Side by Side Diff: public/web/WebDOMActivityLogger.h

Issue 257803006: Fixing wrong extension ID in Activity Log entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: ActivityLogger moved to ScriptState Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 class WebDOMActivityLogger { 41 class WebDOMActivityLogger {
42 public: 42 public:
43 virtual ~WebDOMActivityLogger() { } 43 virtual ~WebDOMActivityLogger() { }
44 44
45 virtual void logGetter(const WebString& apiName, const WebURL& url, const We bString& title) { } 45 virtual void logGetter(const WebString& apiName, const WebURL& url, const We bString& title) { }
46 virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value> & newValue, const WebURL& url, const WebString& title) { } 46 virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value> & newValue, const WebURL& url, const WebString& title) { }
47 virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value> & newValue, const v8::Handle<v8::Value>& oldValue, const WebURL& url, const WebS tring& title) { } 47 virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value> & newValue, const v8::Handle<v8::Value>& oldValue, const WebURL& url, const WebS tring& title) { }
48 virtual void logMethod(const WebString& apiName, int argc, const v8::Handle< v8::Value>* argv, const WebURL& url, const WebString& title) { } 48 virtual void logMethod(const WebString& apiName, int argc, const v8::Handle< v8::Value>* argv, const WebURL& url, const WebString& title) { }
49 }; 49 };
50 50
51 // Checks if a logger already exists for the world identified 51 // Checks if a logger already exists for the world identified by worldId and
52 // by worldId (worldId may be 0 identifying the main world). 52 // extensionID (worldId may be 0 identifying the main world). Extension ID is
Jeffrey Yasskin 2014/05/08 00:17:34 Extension ID isn't mentioned in the signature.
pmarch 2014/05/08 01:14:05 Done.
53 // used only in the case of main world and ignored otherwise.
54 BLINK_EXPORT bool hasDOMActivityLogger(int worldId, const WebString&);
55
56 // Checks if the provided logger is non-null and if so associates it with the
57 // world identified by worldId and extension ID (worldId may be 0 identifying
58 // the main world). The extension ID is ignored for other worlds than the main
59 // one.
60 BLINK_EXPORT void setDOMActivityLogger(int worldId, const WebString&, WebDOMActi vityLogger*);
61
62 // TODO(pmarch): remove the following two methods after modifying Chrome to
63 // use the above ones.
53 BLINK_EXPORT bool hasDOMActivityLogger(int worldId); 64 BLINK_EXPORT bool hasDOMActivityLogger(int worldId);
54
55 // Checks if the provided logger is non-null and if so associates it
56 // with the world identified by worldId (worldId may be 0 identifying the main w orld).
57 BLINK_EXPORT void setDOMActivityLogger(int worldId, WebDOMActivityLogger*); 65 BLINK_EXPORT void setDOMActivityLogger(int worldId, WebDOMActivityLogger*);
58 66
59 } // namespace blink 67 } // namespace blink
60 68
61 #endif 69 #endif
OLDNEW
« Source/bindings/v8/V8DOMActivityLogger.cpp ('K') | « Source/web/WebDOMActivityLogger.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698