Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: Source/bindings/v8/V8DOMActivityLogger.h

Issue 257803006: Fixing wrong extension ID in Activity Log entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: typo Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #ifndef V8DOMActivityLogger_h 31 #ifndef V8DOMActivityLogger_h
32 #define V8DOMActivityLogger_h 32 #define V8DOMActivityLogger_h
33 33
34 #include "wtf/PassOwnPtr.h" 34 #include "wtf/PassOwnPtr.h"
35 #include "wtf/text/WTFString.h" 35 #include "wtf/text/WTFString.h"
36 #include <v8.h> 36 #include <v8.h>
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class KURL;
41
40 class V8DOMActivityLogger { 42 class V8DOMActivityLogger {
41 public: 43 public:
42 virtual ~V8DOMActivityLogger() { } 44 virtual ~V8DOMActivityLogger() { }
43 45
44 virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value >* argv, const String& extraInfo) { } 46 virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value >* argv, const String& extraInfo) { }
45 47
46 // Associates a logger with the world identified by worldId (worlId may be 0 48 // Associates a logger with the world identified by worldId (worlId may be 0
47 // identifying the main world). 49 // identifying the main world) and extension ID. Extension ID is used to
48 static void setActivityLogger(int worldId, PassOwnPtr<V8DOMActivityLogger>); 50 // identify a logger for main world only (worldId == 0). If the world is not
49 static V8DOMActivityLogger* activityLogger(int worldId); 51 // a main world, an extension ID is ignored.
mvrable 2014/04/29 20:15:32 Maybe it's worth adding some text in the comment h
pmarch 2014/05/07 15:28:24 Done.
52 static void setActivityLogger(int worldId, const String&, PassOwnPtr<V8DOMAc tivityLogger>);
53 static V8DOMActivityLogger* activityLogger(int worldId, const String&);
54 static V8DOMActivityLogger* activityLogger(int worldId, const KURL&);
55
50 }; 56 };
51 57
52 } // namespace WebCore 58 } // namespace WebCore
53 59
54 #endif // V8DOMActivityLogger_h 60 #endif // V8DOMActivityLogger_h
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/V8DOMActivityLogger.cpp » ('j') | Source/bindings/v8/V8DOMActivityLogger.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698