Fixing wrong extension ID in Activity Log entries.

Source/bindings/v8/V8DOMActivityLogger.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef V8DOMActivityLogger_h
 #define V8DOMActivityLogger_h
 
 #include "wtf/PassOwnPtr.h"
 #include "wtf/text/WTFString.h"
 #include <v8.h>
 
 namespace WebCore {
 
+class KURL;
+
 class V8DOMActivityLogger {
 public:
     virtual ~V8DOMActivityLogger() { }
 
     virtual void logGetter(const String& apiName) { }
     virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& newValue) { }
     virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& newValue, const v8::Handle<v8::Value>& oldValue) { }
     virtual void logMethod(const String& apiName, int argc, const v8::Handle<v8::Value>* argv) { }
 
     // Associates a logger with the world identified by worldId (worlId may be 0
-    // identifying the main world).
-    static void setActivityLogger(int worldId, PassOwnPtr<V8DOMActivityLogger>);
-    static V8DOMActivityLogger* activityLogger(int worldId);
+    // identifying the main world) and extension ID. Extension ID is used to
+    // identify a logger for main world only (worldId == 0). If the world is not
+    // a main world, an extension ID is ignored.
+    //
+    // A render process may host multiple extensions when the browser hits a

[haraken, 2014/05/08 23:47:45]

render => renderer

[pmarch, 2014/05/09 14:53:52]

Done.

+    // renderer process limit. Thus, within a single render there may be

[haraken, 2014/05/08 23:47:45]

render => renderer

[pmarch, 2014/05/09 14:53:52]

Done.

+    // multiple main worlds (worldId == 0) that corresponds to different
+    // extensions. In order to find an appropriate logger for an extension's
+    // main world in such cases, we require an extension ID. Otherwise,

[haraken, 2014/05/08 23:47:45]

This comment is misleading (e.g., "there may be multiple main worlds",
"extension's main world").

Let's make the following point clear:

- There is only one main world in one renderer process.
- If we reach the renderer process limit, we assign multiple extensions to the
main world of one renderer process. Thus we need an extension ID to distinguish
the extensions in the main world.

[pmarch, 2014/05/09 14:53:52]

Done.

+    // extension activities may be logged under a wrong extension ID.
+    static void setActivityLogger(int worldId, const String&, PassOwnPtr<V8DOMActivityLogger>);
+    static V8DOMActivityLogger* activityLogger(int worldId, const String&);

[haraken, 2014/05/08 23:47:45]

Can we make this a private method?

[pmarch, 2014/05/09 14:53:52]

No, as it is called from WebDOMActivityLogger.cpp

+    static V8DOMActivityLogger* activityLogger(int worldId, const KURL&);
+
 };
 
 } // namespace WebCore
 
 #endif // V8DOMActivityLogger_h