Issue 257803005: Expose promise status through promise mirror.

Issue 257803005: Expose promise status through promise mirror. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
aandrey, rossberg, yurys

CC:
v8-dev, yurys, aandrey, Alexandra Mikhaylova

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Expose promise status through promise mirror. R=aandrey@chromium.org, rossberg@chromium.org, yurys@chromium.org BUG=v8:3093 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=20988

Patch Set 2 : addressed comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -4 lines)			Patch
M	src/mirror-debugger.js	View	1	10 chunks	+53 lines, -4 lines	0 comments	Download
M	src/promise.js	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	test/mjsunit/es6/mirror-promises.js	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2014/04/25 13:17:50, Yang wrote: This is obviously only the start. We want to do ...

6 years, 8 months ago (2014-04-25 13:19:51 UTC) #2

rossberg

https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js File src/mirror-debugger.js (right): https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js#newcode1216 src/mirror-debugger.js:1216: PromiseMirror.Pending = 0; Instead of defining these constants, the ...

6 years, 8 months ago (2014-04-25 13:29:45 UTC) #4

aandrey

lgtm https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js File src/mirror-debugger.js (right): https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js#newcode1212 src/mirror-debugger.js:1212: return this.promise_; did you mean this.value_ ?

6 years, 8 months ago (2014-04-25 13:38:25 UTC) #5

Yang

addressed comments. https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js File src/mirror-debugger.js (right): https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js#newcode1212 src/mirror-debugger.js:1212: return this.promise_; On 2014/04/25 13:38:25, aandrey wrote: ...

6 years, 8 months ago (2014-04-25 13:42:51 UTC) #6

Yang

6 years, 8 months ago (2014-04-25 14:01:11 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 manually as r20988 (presubmit successful).

Expand Messages | Collapse Messages