Add a test for toggling logging in PasswordAutofillAgent

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
@@ skipping 162 matching lines @@
 
   // Simulates the fill password form message being sent to the renderer.
   // We use that so we don't have to make RenderView::OnFillPasswordForm()
   // protected.
   void SimulateOnFillPasswordForm(
       const PasswordFormFillData& fill_data) {
     AutofillMsg_FillPasswordForm msg(0, fill_data);
     password_autofill_->OnMessageReceived(msg);
   }
 
+  void SendVisiblePasswordForms() {

[vabr (Chromium), 2014/04/28 14:31:10]

Here I'm piggybacking on PasswordAutofillAgentTest being a friend of
PasswordAutofillAgent to call the private SendPasswordForms.

Alternatively I could also make SendPasswordForms protected in
PasswordAutofillAgent, elevate to public in TestPasswordAutofillAgent, and call
directly from the test cases.

The former approach is less code and looks more in line with the extisting
practice in this test, but I'm happy to switch if required.

[Ilya Sherman, 2014/04/28 21:13:41]

It would be nice to someday get rid of the friend declarations, but not
necessary to do as part of this CL.

[vabr (Chromium), 2014/04/29 07:45:18]

I agree with both -- getting rid of the friend declarations, and also not doing
it in this CL. :) I'll keep it in mind (http://crbug.com/368160) as a good
filler, or onboarding, task.

+    password_autofill_->SendPasswordForms(GetMainFrame(),
+                                          /*only_visible=*/true);

[Ilya Sherman, 2014/04/28 21:13:41]

Optional nit: I'd write this as "true /* only_visible */".

[vabr (Chromium), 2014/04/29 07:45:18]

Done.

+  }
+
   virtual void SetUp() {
     ChromeRenderViewTest::SetUp();
 
     // Add a preferred login and an additional login to the FillData.
     username1_ = ASCIIToUTF16(kAliceUsername);
     password1_ = ASCIIToUTF16(kAlicePassword);
     username2_ = ASCIIToUTF16(kBobUsername);
     password2_ = ASCIIToUTF16(kBobPassword);
     username3_ = ASCIIToUTF16(kCarolUsername);
     password3_ = ASCIIToUTF16(kCarolPassword);
@@ skipping 847 matching lines @@
       username_element_, kAliceUsername, kAlicePassword));
   CheckTextFieldsDOMState(kAliceUsername, true, kAlicePassword, true);
 
   // Try accepting a suggestion with a password different from the one that was
   // initially sent to the renderer.
   EXPECT_TRUE(password_autofill_->AcceptSuggestion(
       username_element_, kBobUsername, kCarolPassword));
   CheckTextFieldsDOMState(kBobUsername, true, kCarolPassword, true);
 }
 
+// Tests that logging is off by default.
+TEST_F(PasswordAutofillAgentTest, OnChangeLoggingStateNoMessage) {

[Ilya Sherman, 2014/04/28 21:13:41]

Optional nit: I'd name this "OnChangeLoggingState_NoMessage", so that it's
easier to identify the subset of tests that are most closely related to one
another.

[vabr (Chromium), 2014/04/29 07:45:18]

Done.

+  render_thread_->sink().ClearMessages();
+  SendVisiblePasswordForms();
+  const IPC::Message* message = render_thread_->sink().GetFirstMessageMatching(
+      AutofillHostMsg_RecordSavePasswordProgress::ID);
+  EXPECT_FALSE(message);
+}
+
+// Test that logging can be turned on by a message.
+TEST_F(PasswordAutofillAgentTest, OnChangeLoggingStateActivated) {
+  // Up-cast to access OnMessageReceived, which is private in the agent.
+  IPC::Listener* const agent_listener(password_autofill_);

[Ilya Sherman, 2014/04/28 21:13:41]

nit: Please use a static_cast for casting.

[vabr (Chromium), 2014/04/29 07:45:18]

Done.

+
+  // Turn the logging on.
+  AutofillMsg_ChangeLoggingState msg_activate(0, true);
+  EXPECT_TRUE(agent_listener->OnMessageReceived(msg_activate));
+
+  render_thread_->sink().ClearMessages();
+  SendVisiblePasswordForms();
+  const IPC::Message* message = render_thread_->sink().GetFirstMessageMatching(
+      AutofillHostMsg_RecordSavePasswordProgress::ID);
+  EXPECT_TRUE(message);
+}
+
+// Test that logging can be turned off by a message.
+TEST_F(PasswordAutofillAgentTest, OnChangeLoggingStateDeactivated) {
+  // Up-cast to access OnMessageReceived, which is private in the agent.
+  IPC::Listener* const agent_listener(password_autofill_);
+
+  // Turn the logging on and then off.
+  AutofillMsg_ChangeLoggingState msg_activate(0, /*active=*/true);
+  EXPECT_TRUE(agent_listener->OnMessageReceived(msg_activate));
+  AutofillMsg_ChangeLoggingState msg_deactivate(0, /*active=*/false);
+  EXPECT_TRUE(agent_listener->OnMessageReceived(msg_deactivate));
+
+  render_thread_->sink().ClearMessages();
+  SendVisiblePasswordForms();
+  const IPC::Message* message = render_thread_->sink().GetFirstMessageMatching(
+      AutofillHostMsg_RecordSavePasswordProgress::ID);
+  EXPECT_FALSE(message);
+}
+
 }  // namespace autofill