Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2578023002: ServiceWorker: Stop don't send a message before connection established (Closed)
Patch Set: Fixed wrong DCHECK Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 4c3009f86f96cda46e19dfa41187140d5cfb94e8..72ad69c69ca459c0fb672d6f9ebf3209f7e6ea78 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -496,7 +496,8 @@ void ServiceWorkerVersion::StopWorker(const StatusCallback& callback) {
return;
}
- if (stop_callbacks_.empty()) {
+ if (running_status() == EmbeddedWorkerStatus::STARTING ||
+ running_status() == EmbeddedWorkerStatus::RUNNING) {
falken 2016/12/20 09:12:07 How about turning lines 494 and 499-500 into a swi
shimazu 2017/01/05 06:02:41 Done.
ServiceWorkerStatusCode status = embedded_worker_->Stop();
if (status != SERVICE_WORKER_OK) {
RunSoon(base::Bind(callback, status));

Powered by Google App Engine
This is Rietveld 408576698