content/renderer/service_worker/embedded_worker_instance_client_impl.h - Issue 2578023002: ServiceWorker: Stop don't send a message before connection established

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.h

Issue 2578023002: ServiceWorker: Stop don't send a message before connection established (Closed)

Patch Set: Addressed comments from nhiroki@ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_instance.cc ('K') | « content/browser/service_worker/embedded_worker_instance_unittest.cc ('k') | content/renderer/service_worker/embedded_worker_instance_client_impl.cc » ('j') | content/renderer/service_worker/embedded_worker_instance_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_instance_client_impl.h

diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.h b/content/renderer/service_worker/embedded_worker_instance_client_impl.h

index 1b3d27d99457acdfe6444299d42c946c811eb963..35d325978442646ae46f5a4c89840aeffb8e8b91 100644

--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.h

+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.h

@@ -5,6 +5,8 @@

#ifndef CONTENT_RENDERER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_CLIENT_IMPL_H_

#define CONTENT_RENDERER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_CLIENT_IMPL_H_

+#include <vector>

#include "base/id_map.h"

#include "base/optional.h"

#include "content/child/child_thread_impl.h"

@@ -56,7 +58,7 @@ class EmbeddedWorkerInstanceClientImpl

// not running.

EmbeddedWorkerDispatcher::WorkerWrapper* wrapper_;

- StopWorkerCallback stop_callback_;

+ std::vector<StopWorkerCallback> stop_callbacks_;

DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerInstanceClientImpl);

};