Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Issue 2578023002: ServiceWorker: Stop don't send a message before connection established (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/embedded_worker_instance_client_impl.cc
diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
index 38014c8cc62640fcf7258ef9d588d784c2c0b1c3..fa37494f5f946357b78d6605cfa12b163b535fe0 100644
--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
@@ -61,7 +61,6 @@ void EmbeddedWorkerInstanceClientImpl::StartWorker(
void EmbeddedWorkerInstanceClientImpl::StopWorker(
const StopWorkerCallback& callback) {
DCHECK(ChildThreadImpl::current());
- DCHECK(embedded_worker_id_);
nhiroki 2016/12/15 05:43:26 Instead of removing this, can you move this after
shimazu 2016/12/15 08:52:28 Done.
// StopWorker is possible to be called twice or before StartWorker().
if (stop_callback_ || !wrapper_)
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698