Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2578003002: Move |GetCanonicalEncodingNameByAliasName| to base/i18n (Closed)
Patch Set: ucnv_getStandardName Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 2d7a02d61fe879e4dd3f804febcb773bdd14a7b8..61468804a2956c179c14ae531fb459819a62379b 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -14,6 +14,7 @@
#include "base/bind_helpers.h"
#include "base/command_line.h"
#include "base/files/scoped_file.h"
+#include "base/i18n/character_encoding.h"
#include "base/json/json_reader.h"
#include "base/lazy_instance.h"
#include "base/macros.h"
@@ -39,7 +40,6 @@
#include "chrome/browser/browsing_data/origin_filter_builder.h"
#include "chrome/browser/browsing_data/registrable_domain_filter_builder.h"
#include "chrome/browser/budget_service/budget_service_impl.h"
-#include "chrome/browser/character_encoding.h"
#include "chrome/browser/chrome_content_browser_client_parts.h"
#include "chrome/browser/chrome_net_benchmarking_message_filter.h"
#include "chrome/browser/chrome_quota_permission_context.h"
@@ -1411,11 +1411,6 @@ bool ChromeContentBrowserClient::ShouldAssignSiteForURL(const GURL& url) {
return !url.SchemeIs(chrome::kChromeNativeScheme);
}
-std::string ChromeContentBrowserClient::GetCanonicalEncodingNameByAliasName(
- const std::string& alias_name) {
- return ::GetCanonicalEncodingNameByAliasName(alias_name);
-}
-
namespace {
bool IsAutoReloadEnabled() {
@@ -2546,8 +2541,8 @@ void ChromeContentBrowserClient::OverrideWebkitPrefs(
#endif
// Make sure we will set the default_encoding with canonical encoding name.
- web_prefs->default_encoding = GetCanonicalEncodingNameByAliasName(
- web_prefs->default_encoding);
+ web_prefs->default_encoding =
+ base::GetCanonicalEncodingNameByAliasName(web_prefs->default_encoding);
if (web_prefs->default_encoding.empty()) {
prefs->ClearPref(prefs::kDefaultCharset);
web_prefs->default_encoding = prefs->GetString(prefs::kDefaultCharset);

Powered by Google App Engine
This is Rietveld 408576698