Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(341)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/character_encoding.h
Issue
2578003002
:
Move |GetCanonicalEncodingNameByAliasName| to base/i18n (Closed)
Patch Set: rebased
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
android_webview/browser/aw_content_browser_client.h
android_webview/browser/aw_content_browser_client.cc
base/BUILD.gn
base/i18n/character_encoding.h
base/i18n/character_encoding.cc
base/i18n/character_encoding_unittest.cc
chrome/browser/BUILD.gn
chrome/browser/character_encoding.h
chrome/browser/character_encoding.cc
chrome/browser/character_encoding_unittest.cc
chrome/browser/chrome_content_browser_client.h
chrome/browser/chrome_content_browser_client.cc
chrome/test/BUILD.gn
content/browser/web_contents/web_contents_impl.cc
content/public/browser/content_browser_client.h
content/public/browser/content_browser_client.cc
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/BUILD.gn
('k') |
chrome/browser/character_encoding.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#ifndef CHROME_BROWSER_CHARACTER_ENCODING_H_
6
#define CHROME_BROWSER_CHARACTER_ENCODING_H_
7
8
#include <string>
9
10
// Return canonical encoding name according to the encoding alias name.
11
// TODO(jinsukkim): Move this to somewhere under content/.
12
std::string GetCanonicalEncodingNameByAliasName(const std::string& alias_name);
13
14
#endif // CHROME_BROWSER_CHARACTER_ENCODING_H_
OLD
NEW
« no previous file with comments
|
« chrome/browser/BUILD.gn
('k') |
chrome/browser/character_encoding.cc »
('j') |
no next file with comments »
Issue 2578003002: Move |GetCanonicalEncodingNameByAliasName| to base/i18n (Closed)
Created 4 years ago by Jinsuk Kim
Modified 3 years, 11 months ago
Reviewers: jungshik at Google, dcheng, nasko, michaelbai, sky
Base URL:
Comments: 14
This is Rietveld
408576698