base/i18n/character_encoding_unittest.cc - Issue 2578003002: Move |GetCanonicalEncodingNameByAliasName| to base/i18n

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/i18n/character_encoding_unittest.cc

Issue 2578003002: Move |GetCanonicalEncodingNameByAliasName| to base/i18n (Closed)

Patch Set: return const char* Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/i18n/character_encoding.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 namespace base {

	10

	11 TEST(CharacterEncodingTest, GetCanonicalEncodingNameByAliasName) {

	12 EXPECT_STREQ("Big5", GetCanonicalEncodingNameByAliasName("Big5"));

	13 EXPECT_STREQ("windows-874",

	14 GetCanonicalEncodingNameByAliasName("windows-874"));

	15 EXPECT_STREQ("ISO-8859-8", GetCanonicalEncodingNameByAliasName("ISO-8859-8"));

	16

	17 // Non-canonical alias names should be converted to a canonical one.

	18 EXPECT_STREQ("UTF-8", GetCanonicalEncodingNameByAliasName("utf8"));

	19 EXPECT_STREQ("gb18030", GetCanonicalEncodingNameByAliasName("GB18030"));

	20 EXPECT_STREQ("windows-874", GetCanonicalEncodingNameByAliasName("tis-620"));

	21 EXPECT_STREQ("EUC-KR", GetCanonicalEncodingNameByAliasName("ks_c_5601-1987"));

	22 }

	23

	24 } // namespace base

OLD	NEW