third_party/lcms2-2.6/src/cmsplugin.c - Issue 2577963007: lcms: Sanitize floating point read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/lcms2-2.6/src/cmsplugin.c

Issue 2577963007: lcms: Sanitize floating point read (Closed)

Patch Set: lcms: Sanitize floating point read Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/lcms2-2.6/src/cmsplugin.c

diff --git a/third_party/lcms2-2.6/src/cmsplugin.c b/third_party/lcms2-2.6/src/cmsplugin.c

index b95befbd96a445a543f07b74b609ffa892cf2de6..4ba998bb933313bdf06769a538fad348ceeb50cf 100644

--- a/third_party/lcms2-2.6/src/cmsplugin.c

+++ b/third_party/lcms2-2.6/src/cmsplugin.c

@@ -182,7 +182,9 @@ cmsBool CMSEXPORT _cmsReadFloat32Number(cmsIOHANDLER* io, cmsFloat32Number* n)

if (isnan(*n))

return FALSE;

}

- return TRUE;

+ // fpclassify() required by C99

+ return ((fpclassify(*n) == FP_ZERO) || (fpclassify(*n) == FP_NORMAL));

Tom Sepez 2016/12/16 18:27:34 nit: overparenthesized (2 levels).

kcwu 2016/12/17 03:32:06 Done.

}

« no previous file with comments | « third_party/lcms2-2.6/README.pdfium ('k') | no next file » | no next file with comments »