Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: pkg/analyzer/lib/src/generated/package.dart

Issue 2577943003: Use AnalysisOptions.signature as a way to check compatibility. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | pkg/analyzer/lib/src/generated/sdk.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/package.dart
diff --git a/pkg/analyzer/lib/src/generated/package.dart b/pkg/analyzer/lib/src/generated/package.dart
index dddce5a037b4d96b0089fb15ec24b04de6a29720..5983dd3ab9eebaac1af865041edd4c692651614e 100644
--- a/pkg/analyzer/lib/src/generated/package.dart
+++ b/pkg/analyzer/lib/src/generated/package.dart
@@ -158,7 +158,7 @@ class PackageDescription {
@override
int get hashCode {
int hashCode = 0;
- for (int value in options.encodeCrossContextOptions()) {
+ for (int value in options.signature) {
hashCode = JenkinsSmiHash.combine(hashCode, value);
}
hashCode = JenkinsSmiHash.combine(hashCode, id.hashCode);
@@ -170,9 +170,8 @@ class PackageDescription {
bool operator ==(Object other) {
return other is PackageDescription &&
other.sdk == sdk &&
- AnalysisOptions.crossContextOptionsEqual(
- other.options.encodeCrossContextOptions(),
- options.encodeCrossContextOptions()) &&
+ AnalysisOptions.signaturesEqual(
+ other.options.signature, options.signature) &&
other.id == id;
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | pkg/analyzer/lib/src/generated/sdk.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698