Update VideoFrameScheduler API and add clockless and testing implementations.

Update VideoFrameScheduler API and add clockless and testing implementations.

API changes:
  - Frame done callbacks must not be reentrant
  - Reset is fire-and-forget; frames are no longer return via the done callback

BUG=110814
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266635

[scherkus (not reviewing), 2014-04-25 23:54:23]

xhwang: here's one more that I split off from
https://codereview.chromium.org/237353007/

[xhwang, 2014-04-28 16:35:47]

lgtm % nits

https://codereview.chromium.org/257793004/diff/40001/media/filters/clockless_...
File media/filters/clockless_video_frame_scheduler.cc (right):

https://codereview.chromium.org/257793004/diff/40001/media/filters/clockless_...
media/filters/clockless_video_frame_scheduler.cc:24: base::TimeTicks wall_ticks,
/* wall_ticks */ to make clear that it's not used?

https://codereview.chromium.org/257793004/diff/40001/media/filters/test_video...
File media/filters/test_video_frame_scheduler.h (right):

https://codereview.chromium.org/257793004/diff/40001/media/filters/test_video...
media/filters/test_video_frame_scheduler.h:21: ~ScheduledFrame();
nit: this dtor is not virtual and does nothing; no need to declare/define it?

https://codereview.chromium.org/257793004/diff/40001/media/filters/test_video...
media/filters/test_video_frame_scheduler.h:43: const
std::vector<ScheduledFrame>& scheduled_frames() {
nit: make this method const as well?

[scherkus (not reviewing), 2014-04-28 17:03:45]

https://codereview.chromium.org/257793004/diff/40001/media/filters/clockless_...
File media/filters/clockless_video_frame_scheduler.cc (right):

https://codereview.chromium.org/257793004/diff/40001/media/filters/clockless_...
media/filters/clockless_video_frame_scheduler.cc:24: base::TimeTicks wall_ticks,
On 2014/04/28 16:35:48, xhwang wrote:
> /* wall_ticks */ to make clear that it's not used?

Done.

https://codereview.chromium.org/257793004/diff/40001/media/filters/test_video...
File media/filters/test_video_frame_scheduler.h (right):

https://codereview.chromium.org/257793004/diff/40001/media/filters/test_video...
media/filters/test_video_frame_scheduler.h:21: ~ScheduledFrame();
On 2014/04/28 16:35:48, xhwang wrote:
> nit: this dtor is not virtual and does nothing; no need to declare/define it?

this isn't a POD struct, so an explicit dtor is required

../../media/filters/test_video_frame_scheduler.h:17:3: error: [chromium-style]
Complex class/struct needs an explicit out-of-line destructor
  struct ScheduledFrame {
  ^

https://codereview.chromium.org/257793004/diff/40001/media/filters/test_video...
media/filters/test_video_frame_scheduler.h:43: const
std::vector<ScheduledFrame>& scheduled_frames() {
On 2014/04/28 16:35:48, xhwang wrote:
> nit: make this method const as well?

Done.

[scherkus (not reviewing), 2014-04-28 17:03:55]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:05:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/257793004/60001

[commit-bot: I haz the power, 2014-04-28 19:50:07]

Change committed as 266635