Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: pkg/analysis_server/lib/src/computer/new_notifications.dart

Issue 2577913002: Apply error processors in the new driver (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/notification_analysis_options_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/computer/new_notifications.dart
diff --git a/pkg/analysis_server/lib/src/computer/new_notifications.dart b/pkg/analysis_server/lib/src/computer/new_notifications.dart
index 8511e264407eba7d4fa2e0f4c4f90f550d0b458e..2d575a938c32ed8b7d3d2cc4d039a8e8d41e721b 100644
--- a/pkg/analysis_server/lib/src/computer/new_notifications.dart
+++ b/pkg/analysis_server/lib/src/computer/new_notifications.dart
@@ -9,7 +9,6 @@ import 'package:analysis_server/src/domains/analysis/navigation_dart.dart';
import 'package:analysis_server/src/domains/analysis/occurrences.dart';
import 'package:analysis_server/src/domains/analysis/occurrences_dart.dart';
import 'package:analysis_server/src/protocol_server.dart' as protocol;
-import 'package:analyzer/error/error.dart';
import 'package:analyzer/src/dart/analysis/driver.dart';
void new_sendDartNotificationNavigation(
@@ -39,11 +38,8 @@ void new_sendDartNotificationOccurrences(
void new_sendErrorNotification(
AnalysisServer analysisServer, AnalysisResult result) {
- var serverErrors = <protocol.AnalysisError>[];
- for (AnalysisError error in result.errors) {
- serverErrors
- .add(protocol.newAnalysisError_fromEngine(result.lineInfo, error));
- }
+ var serverErrors = protocol.doAnalysisError_listFromEngine(
+ result.driver.analysisOptions, result.lineInfo, result.errors);
var params = new protocol.AnalysisErrorsParams(result.path, serverErrors);
analysisServer.sendNotification(params.toNotification());
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/notification_analysis_options_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698