third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2577893004: position:fixed content is not offset by relative positioned ancestors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2577893004: position:fixed content is not offset by relative positioned ancestors (Closed)

Patch Set: position:fixed content is not offset by relative positioned ancestors Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index dd6a22bdd6c9d4ee55543229f423edab9d1a2331..fb3c6cb78c8784e627960e94620930bb96a59171 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -4170,6 +4170,8 @@ void LayoutBox::computeBlockStaticDistance(

continue;

const LayoutBox& box = *toLayoutBox(curr);

staticLogicalTop += box.logicalTop();

+ if (box.isInFlowPositioned())

+ staticLogicalTop += box.offsetForInFlowPosition().height();

if (!box.isLayoutFlowThread())

continue;

// We're walking out of a flowthread here. This flow thread is not in the