Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: tools/gn/xcode_writer.cc

Issue 2577753002: [Refactor Xcode Objects] Decouple file references and indexing target. (Closed)
Patch Set: Rename one PBXProject::AddSourceFile to PBXProject::AddSourceFileForIndexingTarget Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/xcode_object.h ('K') | « tools/gn/xcode_object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_writer.cc
diff --git a/tools/gn/xcode_writer.cc b/tools/gn/xcode_writer.cc
index 633a1c8db5ea35b354ff3bfb5297aa3c1628dae4..6f6b0d2bce66e7b94d4a711eb531de0477cfb372 100644
--- a/tools/gn/xcode_writer.cc
+++ b/tools/gn/xcode_writer.cc
@@ -353,7 +353,7 @@ void XcodeWriter::CreateSourcesProject(
for (const SourceFile& source : sources) {
std::string source_file =
RebasePath(source.value(), source_dir, absolute_source_path);
- sources_for_indexing->AddSourceFile(source_file);
+ sources_for_indexing->AddSourceFileToIndexingTarget(source_file);
}
projects_.push_back(std::move(sources_for_indexing));
« tools/gn/xcode_object.h ('K') | « tools/gn/xcode_object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698