Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5229)

Unified Diff: chromecast/media/base/BUILD.gn

Issue 2577743002: [chromecast] Deletes libcast_media_1.0_default_core. (Closed)
Patch Set: rebase + simplify libcast_media target Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/media/BUILD.gn ('k') | chromecast/media/base/cast_media_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/base/BUILD.gn
diff --git a/chromecast/media/base/BUILD.gn b/chromecast/media/base/BUILD.gn
index f71222c9954ca75d256199f22d971ef7c8250015..6cdce89fd6dc7d931afd03b7a8e09a6c5d007b56 100644
--- a/chromecast/media/base/BUILD.gn
+++ b/chromecast/media/base/BUILD.gn
@@ -58,81 +58,4 @@ source_set("base") {
"//media",
"//ui/gfx/geometry",
]
-
- if (is_android) {
- deps += [ ":libcast_media_1.0_android" ]
- } else {
- deps += [ ":libcast_media_1.0" ]
- }
-}
-
-# Target for OEM partners to override media shared library, i.e.
-# libcast_media_1.0.so. This target is only used to build executables
-# with correct linkage information.
-shared_library("libcast_media_1.0") {
- sources = [
- "cast_media_dummy.cc",
- ]
-
- public_deps = [
- "//chromecast/public",
- ]
-}
-
-# Target for Android implementation of libcast_media_1.0.
-shared_library("libcast_media_1.0_android") {
- sources = [
- "cast_media_android.cc",
- ]
-
- deps = [
- "//base",
- ]
-
- public_deps = [
- "//chromecast/public",
- ]
-}
-
-# This target can be statically linked into unittests, but production
-# binaries should not depend on this target.
-source_set("libcast_media_1.0_default_core") {
- sources = [
- "cast_media_default.cc",
- ]
-
- public_deps = [
- "//chromecast/public",
- "//chromecast/public/media",
- ]
-
- deps = [
- "//base",
- "//build/config/sanitizers:deps",
- "//chromecast/base",
- "//chromecast/media/cma/backend",
- ]
-}
-
-# Default implementation of libcast_media_1.0.so.
-# TODO(slan): Make this target a loadable_module (crbug/380327)
-shared_library("libcast_media_1.0_default") {
- # Note that it cannot depend on libcast_media_1.0_default_core since a
- # loadable_module include only symbols necessary for source files.
- # So, it should include top-level .cc, here cast_media_default.cc explicitly.
- sources = [
- "cast_media_default.cc",
- ]
-
- public_deps = [
- "//chromecast/public",
- "//chromecast/public/media",
- ]
-
- deps = [
- "//base",
- "//build/config/sanitizers:deps",
- "//chromecast/base",
- "//chromecast/media/cma/backend",
- ]
}
« no previous file with comments | « chromecast/media/BUILD.gn ('k') | chromecast/media/base/cast_media_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698