Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Issue 257773005: Remove the suppression for issue 181502 (races on std::string internals) (Closed)

Created:
6 years, 8 months ago by Alexander Potapenko
Modified:
6 years, 8 months ago
Reviewers:
earthdok
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove the suppression for issue 181502 (races on std::string internals) TSan is using instrumented libc++ now, so these false positives aren't reported anymore. BUG=181502 TBR=earthdok@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/valgrind/tsan_v2/suppressions.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
TBR
6 years, 8 months ago (2014-04-25 11:00:10 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 8 months ago (2014-04-25 11:00:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/257773005/1
6 years, 8 months ago (2014-04-25 13:15:54 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 00:22:13 UTC) #4
Message was sent while issue was closed.
Change committed as 266301

Powered by Google App Engine
This is Rietveld 408576698