Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2576)

Unified Diff: google_apis/gaia/gaia_oauth_client.h

Issue 257773002: Use new people.get api instead of oauth2/v1/userinfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix PD tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gaia/gaia_oauth_client.h
diff --git a/google_apis/gaia/gaia_oauth_client.h b/google_apis/gaia/gaia_oauth_client.h
index 8e01ef6a83a3bdac0a0fbc8c671304b4382f205b..6bbf02c13d2df6b57180682521b27e63726e94d7 100644
--- a/google_apis/gaia/gaia_oauth_client.h
+++ b/google_apis/gaia/gaia_oauth_client.h
@@ -47,6 +47,9 @@ class GaiaOAuthClient {
virtual void OnGetUserEmailResponse(const std::string& user_email) {}
// Invoked on a successful response to the GetUserId request.
virtual void OnGetUserIdResponse(const std::string& user_id) {}
+ // Invoked on a successful response to the GetUserInfo request.
+ virtual void OnGetUserInfoResponse(
+ scoped_ptr<base::DictionaryValue> user_info) {}
// Invoked on a successful response to the GetTokenInfo request.
virtual void OnGetTokenInfoResponse(
scoped_ptr<base::DictionaryValue> token_info) {}
@@ -88,7 +91,7 @@ class GaiaOAuthClient {
int max_retries,
Delegate* delegate);
- // Call the userinfo API, returning the user email address associated
+ // Call the people.get API, returning the user email address associated
// with the given access token. The provided access token must have
// https://www.googleapis.com/auth/userinfo.email as one of its scopes.
// See |max_retries| docs above.
@@ -96,14 +99,23 @@ class GaiaOAuthClient {
int max_retries,
Delegate* delegate);
- // Call the userinfo API, returning the user gaia ID associated
+ // Call the people.get API, returning the user gaia ID associated
// with the given access token. The provided access token must have
- // https://www.googleapis.com/auth/userinfo as one of its scopes.
+ // https://www.googleapis.com/auth/userinfo.profile as one of its scopes.
// See |max_retries| docs above.
void GetUserId(const std::string& oauth_access_token,
int max_retries,
Delegate* delegate);
+ // Call the people.get API, returning the user info associated
+ // with the given access token. The provided access token must have
+ // https://www.googleapis.com/auth/userinfo.email and
+ // https://www.googleapis.com/auth/userinfo.profile as its scopes.
+ // See |max_retries| docs above.
+ void GetUserInfo(const std::string& oauth_access_token,
+ int max_retries,
noms (inactive) 2014/04/25 17:07:40 nit: wrong indentation
Roger Tawa OOO till Jul 10th 2014/04/28 20:44:12 Done.
+ Delegate* delegate);
+
// Call the tokeninfo API, returning a dictionary of response values. The
// provided access token may have any scope, and basic results will be
// returned: issued_to, audience, scope, expires_in, access_type. In

Powered by Google App Engine
This is Rietveld 408576698