Use new people.get api instead of oauth2/v1/userinfo.

chrome/browser/profiles/profile_downloader_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_downloader.h"
 
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/string_piece.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
-std::string GetJSonData(const std::string& full_name,
-                        const std::string& given_name,
-                        const std::string& url,
-                        const std::string& locale) {
+scoped_ptr<base::DictionaryValue> GetJSonData(const std::string& full_name,

[noms (inactive), 2014/04/25 17:07:40]

Can you do something here like in the ProfileDownloader, where you pass the
dictionary as a pointer?

[Roger Tawa OOO till Jul 10th, 2014/04/28 20:44:12]

Done.

+                                              const std::string& given_name,
+                                              const std::string& url,
+                                              const std::string& locale) {
   std::stringstream stream;
   bool started = false;
 
   stream << "{ ";
   if (!full_name.empty()) {
-    stream << "\"name\": \"" << full_name << "\"";
+    stream << "\"displayName\": \"" << full_name << "\"";
     started = true;
   }
   if (!given_name.empty()) {
-    stream << (started ? ", " : "") << "\"given_name\": \"" << given_name
-           << "\"";
+    stream << (started ? ", " : "") << "\"name\": {";
+    stream << "\"givenName\": \"" << given_name
+           << "\"}";
     started = true;
   }
   if (!url.empty()) {
-    stream << (started ? ", " : "") << "\"picture\": \"" << url << "\"";
+    stream << (started ? ", " : "") << "\"image\": {";
+    stream << "\"url\": \"" << url << "\"}";
     started = true;
   }
 
   if (!locale.empty())
-    stream << (started ? ", " : "") << "\"locale\": \"" << locale << "\"";
+    stream << (started ? ", " : "") << "\"language\": \"" << locale << "\"";
 
   stream << " }";
-  return stream.str();
+  base::Value* value = base::JSONReader::Read(stream.str());
+  base::DictionaryValue* dict = NULL;
+  value->GetAsDictionary(&dict);
+  return make_scoped_ptr(dict);
 }
 
 } // namespace
 
 class ProfileDownloaderTest : public testing::Test {
  protected:
   ProfileDownloaderTest() {
   }
 
   virtual ~ProfileDownloaderTest() {
   }
 
   void VerifyWithAccountData(const std::string& full_name,
                              const std::string& given_name,
                              const std::string& url,
                              const std::string& expected_url,
                              const std::string& locale,
                              bool is_valid) {
     base::string16 parsed_full_name;
     base::string16 parsed_given_name;
     std::string parsed_url;
     std::string parsed_locale;
+    scoped_ptr<base::DictionaryValue> dict(
+        GetJSonData(full_name, given_name, url, locale));
     bool result = ProfileDownloader::ParseProfileJSON(
-        GetJSonData(full_name, given_name, url, locale),
+        dict.get(),
         &parsed_full_name,
         &parsed_given_name,
         &parsed_url,
         32,
         &parsed_locale);
     EXPECT_EQ(is_valid, result);
     std::string parsed_full_name_utf8 = base::UTF16ToUTF8(parsed_full_name);
     std::string parsed_given_name_utf8 = base::UTF16ToUTF8(parsed_given_name);
 
     EXPECT_EQ(full_name, parsed_full_name_utf8);
@@ skipping 90 matching lines @@
   // Not default G+ photo
   EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAAAA/G/photo.jpg"));
   // Not default with 6 components
   EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg"));
   // Not default with 7 components
   EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg"));
 }