Add unit tests for NSS-backed SSLPrivateKeys.

net/ssl/ssl_platform_key_chromecast.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <keyhi.h>
 #include <pk11pub.h>
 #include <prerror.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 23 matching lines @@
 
 class SSLPlatformKeyChromecast : public ThreadedSSLPrivateKey::Delegate {
  public:
   SSLPlatformKeyChromecast(crypto::ScopedSECKEYPrivateKey key)
       : key_(std::move(key)) {}
   ~SSLPlatformKeyChromecast() override {}
 
   SSLPrivateKey::Type GetType() override { return SSLPrivateKey::Type::RSA; }
 
   std::vector<SSLPrivateKey::Hash> GetDigestPreferences() override {
-    static const SSLPrivateKey::Hash kHashes[] = {
-        SSLPrivateKey::Hash::SHA256, SSLPrivateKey::Hash::SHA1,
-        SSLPrivateKey::Hash::MD5_SHA1};

[davidben, 2016/12/14 16:03:06]

MD5-SHA1 is weird and isn't advertised. (Doesn't make a difference whether we
advertise here it or not since SSLClientSocketImpl will filter it out, but other
SSLPrivateKey implementations don't list it.) The prefs are used for TLS 1.1 and
below where you always sign MD5-SHA1 for RSA.

-    return std::vector<SSLPrivateKey::Hash>(kHashes,
-                                            kHashes + arraysize(kHashes));
+    return std::vector<SSLPrivateKey::Hash>{SSLPrivateKey::Hash::SHA256,
+                                            SSLPrivateKey::Hash::SHA1};
   }
 
   size_t GetMaxSignatureLengthInBytes() override {
     int len = PK11_SignatureLen(key_.get());
     if (len <= 0)
       return 0;
     return static_cast<size_t>(len);
   }
 
   Error SignDigest(SSLPrivateKey::Hash hash,
@@ skipping 67 matching lines @@
     return ClientKeyStore::GetInstance()->FetchClientCertPrivateKey(
         *certificate);
   }
 
   return make_scoped_refptr(new ThreadedSSLPrivateKey(
       base::MakeUnique<SSLPlatformKeyChromecast>(std::move(key)),
       GetSSLPlatformKeyTaskRunner()));
 }
 
 }  // namespace net